Fix bug of parsing of reactants in building the reaction SMILES #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 69.80% 69.89% +0.08%
==========================================
Files 23 23
Lines 2368 2368
Branches 598 598
==========================================
+ Hits 1653 1655 +2
+ Misses 600 599 -1
+ Partials 115 114 -1
|
skearnes
requested changes
Sep 16, 2023
skearnes
reviewed
Sep 20, 2023
skearnes
approved these changes
Sep 20, 2023
skearnes
reviewed
Sep 20, 2023
The original codes would take anything other than REAGENT, SOLVENT, CATALYST, INTERNAL_STANDARD, PRODUCT as reactant, which is problematic. Because AUTHENTIC_STANDARD, BYPRODUCT, SIDE_PRODUCT are not reactants. Also fixed the imports, duplicates and cleaning up.
FanwangM
force-pushed
the
fix_rxn_smiles
branch
from
6258e86 to
225a456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original codes would take anything other than REAGENT, SOLVENT, CATALYST, INTERNAL_STANDARD, PRODUCT as reactant, which is problematic. Because AUTHENTIC_STANDARD, BYPRODUCT, SIDE_PRODUCT are not reactants.
Also fixed the imports, duplicates and cleaning up.