Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added typescript definitions to js module #757

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Added typescript definitions to js module #757

merged 4 commits into from
Dec 13, 2024

Conversation

daniil-sloboda
Copy link
Contributor

  • Added typescript definitions generation to output of the compilation script.
  • Updated package.json version

@daniil-sloboda
Copy link
Contributor Author

daniil-sloboda commented Dec 12, 2024 •
edited
Loading

@skearnes Hello, can you please take a look at the PR when you have some spare time?

The build is failing because npm install is not a step in the files generation, should I update the CI?

skearnes
skearnes reviewed Dec 12, 2024
View reviewed changes
js/ord-schema/package.json Outdated Show resolved Hide resolved
compile_proto_wrappers.sh Outdated Show resolved Hide resolved
@daniil-sloboda daniil-sloboda linked an issue Dec 13, 2024 that may be closed by this pull request
Update ord-schema repo to support TS open-reaction-database/ord-app#38
Closed
@skearnes
Copy link
Collaborator

Thanks @daniil-sloboda this looks great!

@skearnes skearnes merged commit c38e800 into open-reaction-database:main Dec 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skearnes skearnes skearnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ord-schema repo to support TS
2 participants
@daniil-sloboda @skearnes