fix: test driftage #311
Merged
fix: test driftage #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
approved these changes
Aug 16, 2024
nickytonline
requested changes
Aug 16, 2024
There was a problem hiding this comment.
Thanks for fixing the tests @bdougie! One small change request.
| @@ -98,7 +98,7 @@ test('getPullRequestAPIURL', async () => { | |||
| expect(await getPullRequestAPIURL('https://github.com/open-sauced/ai/pull/164')).toBe('https://api.github.com/repos/open-sauced/ai/pulls/164') | |||
| expect(await getPullRequestAPIURL('https://github.com/open-sauced/ai/pull/163')).toBe('https://api.github.com/repos/open-sauced/ai/pulls/163') | |||
| expect(await getPullRequestAPIURL('https://github.com/open-sauced/ai/compare/some-branch')).toBe('https://api.github.com/repos/open-sauced/ai/compare/beta...some-branch') | |||
| expect(await getPullRequestAPIURL('https://github.com/tailwindlabs/tailwindcss/compare/some-branch')).toBe('https://api.github.com/repos/tailwindlabs/tailwindcss/compare/master...some-branch') | |||
| expect(await getPullRequestAPIURL('https://github.com/tailwindlabs/tailwindcss/compare/some-branch')).toBe('https://api.github.com/repos/tailwindlabs/tailwindcss/compare/next...some-branch') | |||
There was a problem hiding this comment.
This fixes the failure as it looks like the tailwindlabs/tailwindcss project changed a branch name, but, and not for this PR, but I'd probably mock the network request that gets the default branch name for all these tests, i.e.
Lines 73 to 74 in 7ab9847
Co-authored-by: Nick Taylor <nick@nickyt.co>
jpmcb
approved these changes
Aug 19, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
## [1.16.0-beta.1](v1.15.0...v1.16.0-beta.1) (2024-08-20) ### 🍕 Features * adds .prettierrc ([#310](#310)) ([c1f0d1e](c1f0d1e)) * Remove PR description generator ([#308](#308)) ([e342847](e342847)), closes [#307](#307) * Replaces velocity with OSCR ([#309](#309)) ([5a0172d](5a0172d)) ### 🐛 Bug Fixes * Generates a token so the open-sauce bot can push to beta ([#313](#313)) ([985b482](985b482)) * test driftage ([#311](#311)) ([83c2415](83c2415))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
## [1.16.0](v1.15.0...v1.16.0) (2024-08-20) ### 🍕 Features * adds .prettierrc ([#310](#310)) ([c1f0d1e](c1f0d1e)) * Remove PR description generator ([#308](#308)) ([e342847](e342847)), closes [#307](#307) * Replaces velocity with OSCR ([#309](#309)) ([5a0172d](5a0172d)) ### 🐛 Bug Fixes * Generates a token so the open-sauce bot can push to beta ([#313](#313)) ([985b482](985b482)) * test driftage ([#311](#311)) ([83c2415](83c2415))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saw test were failing on a benign change on #310. This fixes the user 404 test and Tailwind's default branch change.
Related Tickets & Documents
#310
#309
#308
Mobile & Desktop Screenshots/Recordings
Steps to QA
npm test
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?