Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove type DateTime and include various upstream changes #5

Closed
wants to merge 1 commit into from
Closed

fix: remove type DateTime and include various upstream changes #5

wants to merge 1 commit into from

Conversation

cecobask
Copy link

@cecobask cecobask commented Sep 19, 2023

Description

This PR fixes the bug #3.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #3.
Relates to: open-sauced/pizza-cli#38
Contains upstream changes from: open-sauced/api/releases/tag/v1.48.0-beta.9

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

Are there any post-deployment tasks we need to perform?

Release a new version of the go-api client.

@cecobask
Copy link
Author

cecobask commented Sep 19, 2023

@jpmcb,

Please, check this out when you have the chance.
If everything is okay, can you merge this pull request?
I will then update my pizza-cli feature branch to reference the origin repo instead of my fork.
Thank you!

@jpmcb jpmcb self-requested a review September 20, 2023 15:57
@jpmcb
Copy link
Member

jpmcb commented Sep 25, 2023

Closed by: 8a8b1fa

Added you as a co-author but ended up making a few tweaks to the generated client code as well. Great work! Let me know what else you need!!

@jpmcb jpmcb closed this Sep 25, 2023
@cecobask cecobask deleted the openapi-date-fix branch September 26, 2023 11:38
@cecobask
Copy link
Author

Thank you! Here I learned something new from you - automating the patching with git apply is quite handy! πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: custom time type not properly (un)marshalled
2 participants