Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use repository fullname to fetch contributors #77

Merged

Conversation

k1nho
Copy link
Contributor

@k1nho k1nho commented Mar 4, 2024

Description

This PR makes the pizza insights command to use repo.FullName rather than repo.Name to fetch contributors.

Before

$ pizza insights contributors https://github.com/hashicorp/terraform 
Repository URL      https://github.com/hashicorp/terraform 
New contributors    0                                    
Recent contributors 0                                     
Alumni contributors 0                                     
Repeat contributors 0                                     

Now

$ pizza insights contributors https://github.com/hashicorp/terraform 
Repository URL      https://github.com/hashicorp/terraform 
New contributors    13                                     
Recent contributors 27                                     
Alumni contributors 10                                     
Repeat contributors 20

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #76

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Kin!!!!

👏🏼👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼

@jpmcb jpmcb requested a review from a team March 4, 2024 22:22
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@jpmcb jpmcb merged commit 5326875 into open-sauced:beta Mar 4, 2024
6 checks passed
open-sauced bot pushed a commit that referenced this pull request Mar 4, 2024
## [1.1.1-beta.4](v1.1.1-beta.3...v1.1.1-beta.4) (2024-03-04)

### 🐛 Bug Fixes

* use repository fullname to fetch contributors ([#77](#77)) ([5326875](5326875))
open-sauced bot pushed a commit that referenced this pull request Aug 30, 2024
## [1.2.0](v1.1.1...v1.2.0) (2024-08-30)

### 📝 Documentation

* updated comment for LoadConfig ([ab5206b](ab5206b))

### ✅ Tests

* added setup and teardown ([aba6310](aba6310))
* added tests for LoadConfig ([2a5f85d](2a5f85d))
* made tests parallel ([2b3d8ca](2b3d8ca))

### 🍕 Features

* added .sauced.yaml and updated CODEOWNERS file ([#109](#109)) ([dfc56cb](dfc56cb))
* added built at to version command ([#94](#94)) ([9960fc0](9960fc0))
* Codeowners generation ([#95](#95)) ([79cf8a2](79cf8a2))
* now generate codeowners checks in user root but also repository root folder for .sauced.yaml ([a0298b1](a0298b1))
* pizza login success page style refresh ([#112](#112)) ([9357dac](9357dac))
* Refactors Auth code into api/ directory ([#105](#105)) ([d851499](d851499))
* Skip semantic-release docker build in favor of buildx building ([d782974](d782974))
* Trim down CLI - remove unused, defunct commands ([#93](#93)) ([7ddd4b9](7ddd4b9))
* Upgrade Go module to use Go 1.22 ([#96](#96)) ([690b6e9](690b6e9))
* Use justfile vs. makefile ([#84](#84)) ([8f38eaf](8f38eaf))

### 🐛 Bug Fixes

* escape non-standard characters in the filename path ([#106](#106)) ([418951f](418951f))
* mark endpoint and beta flags as hidden ([#113](#113)) ([6aa250f](6aa250f))
* move output flag to insights command ([#115](#115)) ([be7f8cd](be7f8cd))
* update supabase keys for auth ([#80](#80)) ([247c431](247c431))
* use repository fullname to fetch contributors ([#77](#77)) ([5326875](5326875))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: pizza insights contributors is broken
3 participants