Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterqueue] Implement blocking queue #11951

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Dec 18, 2024

Description

This PR

  1. Implements blocking memory queue. The queue blocks until the incoming request is successgfully sent out.
  2. Uses blocking queue + queue batcher in place of batch_sender if the feature gate UsePullingBasedExporterQueueBatcher is on.

Link to tracking issue

#8122
#10368

Testing

Documentation

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 90.14085% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (0262609) to head (301d1e0).

Files with missing lines Patch % Lines
exporter/internal/queue/blocking_queue.go 82.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11951      +/-   ##
==========================================
- Coverage   91.62%   91.61%   -0.01%     
==========================================
  Files         447      448       +1     
  Lines       23739    23804      +65     
==========================================
+ Hits        21751    21809      +58     
- Misses       1613     1619       +6     
- Partials      375      376       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

@sfc-gh-sili please rebase and look at the failing CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants