Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Adds BaggageLogRecordProcessor #2354

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

matt-hensley
Copy link
Contributor

@matt-hensley matt-hensley commented Dec 3, 2024

Fixes #2353

Changes

Adds BaggageLogRecordProcessor and relevant tests.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the comp:extensions Things related to OpenTelemetry.Extensions label Dec 3, 2024
@matt-hensley matt-hensley marked this pull request as ready for review December 3, 2024 13:39
@matt-hensley matt-hensley requested a review from a team as a code owner December 3, 2024 13:39
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks for your contribution @matt-hensley 🎉

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (71655ce) to head (1c70d6f).
Report is 654 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2354       +/-   ##
===========================================
+ Coverage   73.91%   91.12%   +17.20%     
===========================================
  Files         267       11      -256     
  Lines        9615      214     -9401     
===========================================
- Hits         7107      195     -6912     
+ Misses       2508       19     -2489     
Flag Coverage Δ
unittests-Extensions 91.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...y.Extensions/Internal/BaggageLogRecordProcessor.cs 100.00% <100.00%> (ø)
...ons/Internal/OpenTelemetryExtensionsEventSource.cs 60.00% <100.00%> (+14.54%) ⬆️
....Extensions/Logs/OpenTelemetryLoggingExtensions.cs 100.00% <100.00%> (ø)
...etry.Extensions/TracerProviderBuilderExtensions.cs 94.44% <100.00%> (+27.77%) ⬆️

... and 263 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, but nothing blocker

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
@github-actions github-actions bot requested a review from CodeBlanch December 5, 2024 22:41
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions Things related to OpenTelemetry.Extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add BaggageLogRecordProcessor to enrich logs with baggage data
6 participants