-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Adds BaggageLogRecordProcessor
#2354
base: main
Are you sure you want to change the base?
[Extensions] Adds BaggageLogRecordProcessor
#2354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks for your contribution @matt-hensley 🎉
src/OpenTelemetry.Extensions/Internal/BaggageLogRecordProcessor.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Extensions.Tests/OpenTelemetry.Extensions.Tests.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/Logs/OpenTelemetryLoggingExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Extensions/Internal/BaggageLogRecordProcessor.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
===========================================
+ Coverage 73.91% 91.12% +17.20%
===========================================
Files 267 11 -256
Lines 9615 214 -9401
===========================================
- Hits 7107 195 -6912
+ Misses 2508 19 -2489
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Extensions/Logs/OpenTelemetryLoggingExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but nothing blocker
src/OpenTelemetry.Extensions/Internal/BaggageLogRecordProcessor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2353
Changes
Adds
BaggageLogRecordProcessor
and relevant tests.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes