-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Semantic Convention handling in AWS libraries. #2367
Open
ppittle
wants to merge
30
commits into
open-telemetry:main
Choose a base branch
from
ppittle:upgrade-aws-semantic-convention
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade Semantic Convention handling in AWS libraries. #2367
ppittle
wants to merge
30
commits into
open-telemetry:main
from
ppittle:upgrade-aws-semantic-convention
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
muhammad-othman,
Oberon00,
rypdal and
srprash
December 6, 2024 04:26
github-actions
bot
added
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.awslambda
Things related to OpenTelemetry.Instrumentation.AWSLambda
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
labels
Dec 6, 2024
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 04:45
da63599
to
3183104
Compare
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 04:55
3183104
to
ddef75b
Compare
github-actions
bot
removed
the
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
label
Dec 6, 2024
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 04:58
ddef75b
to
f62eb8d
Compare
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 05:11
f62eb8d
to
59b59f1
Compare
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 06:19
59b59f1
to
ed49ef0
Compare
Kielek
reviewed
Dec 6, 2024
ppittle
commented
Dec 6, 2024
src/OpenTelemetry.Instrumentation.AWSLambda/OpenTelemetry.Instrumentation.AWSLambda.csproj
Outdated
Show resolved
Hide resolved
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 6, 2024 23:10
ed49ef0
to
1dbdb19
Compare
…semantic convention versions
…ire some additional changes in the Instrumentation.AWSLambda project to accomidate using url.path and url.query instead.
…Attribute calls in core logic
…ent version used by the library. Users must opt-in to newer versions of semantic conventions.
… must have a unique namespace
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 13, 2024 21:08
68b455e
to
bc393a5
Compare
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Semantinc Convention enums
…e reference to that project
ppittle
force-pushed
the
upgrade-aws-semantic-convention
branch
from
December 13, 2024 23:00
bc393a5
to
21379d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:instrumentation.aws
Things related to OpenTelemetry.Instrumentation.AWS
comp:instrumentation.awslambda
Things related to OpenTelemetry.Instrumentation.AWSLambda
comp:resources.aws
Things related to OpenTelemetry.Resources.AWS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
NOTE: This PR is built on top of #2363, #2363 should be merged first.
Changes
Implementation of the design discussed in the Nov 26th OpenTelemetry .NET SIG meeting. This design allows releasing the AWS OTel Contrib libraries as GA while still informing users that underlying Semantic Conventions are experimental.
This is exposed via the
SemanticConventionVersion
enum:Users can choose how to handle this for their applications by either pinning to a specific Semantic Convention version or automatically getting updates the next time they upgrade the AWS Otel nuget packages.
Selection is made by updating the Options object in the builder method.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes