-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing unsafe available check #6920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth (possible?) adding something in CI that runs the tests without unsafe?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6920 +/- ##
============================================
- Coverage 90.10% 90.09% -0.02%
Complexity 6594 6594
============================================
Files 729 729
Lines 19828 19828
Branches 1950 1951 +1
============================================
- Hits 17867 17865 -2
Misses 1369 1369
- Partials 592 594 +2 ☔ View full report in Codecov by Sentry. |
added a test that uses a custom class loader to hide sun.misc.Unsafe from the tested code |
Thanks for the fix! |
Can confirm this fixes the issue. 👍 |
ah I see the problem with using something like
|
Resolves #6913