Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lambda ruby wrapper for layer #1323

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: add lambda ruby wrapper for layer #1323

merged 7 commits into from
May 22, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented May 13, 2024 •
edited
Loading

This PR continues the work from #918.
Since ruby lambda instrumentation is released (rubygems), so it's time to create the actual wrapper for it.

@xuan-cao-swi xuan-cao-swi requested a review from a team May 13, 2024 18:23
mwear
mwear reviewed May 20, 2024
View reviewed changes
ruby/src/layer/wrapper.rb Outdated
Comment on lines 9 to 10
::OpenTelemetry::Instrumentation.registry.register('OpenTelemetry::Instrumentation::AwsLambda')
::OpenTelemetry::Instrumentation.registry.install(['OpenTelemetry::Instrumentation::AwsLambda'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about these two lines. Doesn't Instrumentation::Base do this automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, it should do it automatically, I will remove the registry part.

mwear
mwear approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerbenson
Copy link
Member

Thanks @mwear.

@xuan-cao-swi Before merging this and testing the release process, please update the release-ruby-layer.yml release-group: prod to dev (or remove that line). After we're happy with the build artifact, we can change it back to prod.

@xuan-cao-swi
Copy link
Contributor Author

@xuan-cao-swi Before merging this and testing the release process, please update the release-ruby-layer.yml release-group: prod to dev (or remove that line). After we're happy with the build artifact, we can change it back to prod.

Thanks @tylerbenson , I have updated to dev

@tylerbenson tylerbenson merged commit 4e2e142 into open-telemetry:main May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuan-cao-swi @tylerbenson @mwear