-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping packages to fix build and security issues #275
base: main
Are you sure you want to change the base?
Bumping packages to fix build and security issues #275
Conversation
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
@@ -11,7 +11,7 @@ on: | |||
paths: | |||
|
|||
env: | |||
BENV_IMAGE: quay.io/splunko11ytest/network-explorer-debug/build-env | |||
BENV_IMAGE: public.ecr.aws/u7d6c4a3/solarwinds-opentelemetry-network:build-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should move PR to draft if you are still experimenting with the changes. We shouldn't merge to upstream use of image from solarwinds owned registry
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Signed-off-by: jakub-racek-swi <jakub.racek@solarwinds.com>
Hey @yonch, I was taking another look at the failing unit tests in my otel-network build. I've made some progress with investigating the abseil failures, which is most likely related to some old issue that happens when asan is not applied to the entire build (abseil/abseil-cpp#1524). While investigating the 'render_test', I was trying to start the unit tests locally, but got wildly different test results.
I am wondering how come the unit tests produce different results here in the github actions and when built locally on my machine. This is only with asan, however, as all tests do pass in the regular build. I also wanted to ask how to handle debugging, since there is a |
Hi @jakub-racek-swi ! I'm not sure regarding the ASAN failures. What CPU are you running on? Let me check the debug builds. I remember we used to have a script to run under gdb.. |
So for debugging the kernel collector:
Hope this is what you're looking for.. |
Verified that this PR compiles with the new build image. 👍 My test run with
I didn't get the SEGFAULTs you got -- maybe you changed something since that earlier post? Without ASAN tests seem to pass. |
@jakub-racek-swi the new build image is Are you comfortable changing |
Description: Bumping packages to fix build and security issues - this is accompanied by a PR to the build env, which must be merged first.
Bumping packages to fix build and security issues
Link to tracking Issue:
Testing:
Documentation: