Fix TraceResponse format to match spec (#243)

open-telemetry · Mar 4, 2024 · a7ff7db · a7ff7db
1 parent 62fe1ea
commit a7ff7db
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/Propagation/ServerTiming/src/ServerTimingPropagator.php b/src/Propagation/ServerTiming/src/ServerTimingPropagator.php
@@ -17,8 +17,8 @@
  */
 final class ServerTimingPropagator implements ResponsePropagator
 {
-    const IS_SAMPLED = '1';
-    const NOT_SAMPLED = '0';
+    const IS_SAMPLED = '01';
+    const NOT_SAMPLED = '00';
     const SUPPORTED_VERSION = '00';
     const SERVER_TIMING = 'server-timing';
     const TRACEPARENT = 'traceparent';

diff --git a/src/Propagation/ServerTiming/tests/Unit/PropagatorTest.php b/src/Propagation/ServerTiming/tests/Unit/PropagatorTest.php
@@ -19,8 +19,8 @@ class PropagatorTest extends TestCase
 {
     private const TRACE_ID = '5759e988bd862e3fe1be46a994272793';
     private const SPAN_ID = '53995c3f42cd8ad8';
-    private const TRACERESPONSE_HEADER_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-1';
-    private const TRACERESPONSE_HEADER_NOT_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-0';
+    private const TRACERESPONSE_HEADER_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-01';
+    private const TRACERESPONSE_HEADER_NOT_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-00';
 
     /**
      * @test

diff --git a/src/Propagation/TraceResponse/src/TraceResponsePropagator.php b/src/Propagation/TraceResponse/src/TraceResponsePropagator.php
@@ -17,8 +17,8 @@
  */
 final class TraceResponsePropagator implements ResponsePropagator
 {
-    const IS_SAMPLED = '1';
-    const NOT_SAMPLED = '0';
+    const IS_SAMPLED = '01';
+    const NOT_SAMPLED = '00';
     const SUPPORTED_VERSION = '00';
     const TRACERESPONSE = 'traceresponse';
 

diff --git a/src/Propagation/TraceResponse/tests/Unit/PropagatorTest.php b/src/Propagation/TraceResponse/tests/Unit/PropagatorTest.php
@@ -19,8 +19,8 @@ class PropagatorTest extends TestCase
 {
     private const TRACE_ID = '5759e988bd862e3fe1be46a994272793';
     private const SPAN_ID = '53995c3f42cd8ad8';
-    private const TRACERESPONSE_HEADER_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-1';
-    private const TRACERESPONSE_HEADER_NOT_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-0';
+    private const TRACERESPONSE_HEADER_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-01';
+    private const TRACERESPONSE_HEADER_NOT_SAMPLED = '00-5759e988bd862e3fe1be46a994272793-53995c3f42cd8ad8-00';
 
     /**
      * @test