[symfony] Fix: Set span status according to otel convention (#308)

* Only set error status if we know the response code is 500 or higher. * fix linting error
open-telemetry · Oct 22, 2024 · cf610d5 · cf610d5
1 parent 78a04ce
commit cf610d5
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Instrumentation/Symfony/src/SymfonyInstrumentation.php b/src/Instrumentation/Symfony/src/SymfonyInstrumentation.php
@@ -104,7 +104,9 @@ public static function register(): void
                     $span->recordException($exception, [
                         TraceAttributes::EXCEPTION_ESCAPED => true,
                     ]);
-                    $span->setStatus(StatusCode::STATUS_ERROR, $exception->getMessage());
+                    if (null !== $response && $response->getStatusCode() >= Response::HTTP_INTERNAL_SERVER_ERROR) {
+                        $span->setStatus(StatusCode::STATUS_ERROR, $exception->getMessage());
+                    }
                 }
 
                 if (null === $response) {
@@ -159,8 +161,7 @@ public static function register(): void
                 Span::getCurrent()
                     ->recordException($throwable, [
                         TraceAttributes::EXCEPTION_ESCAPED => true,
-                    ])
-                    ->setStatus(StatusCode::STATUS_ERROR, $throwable->getMessage());
+                    ]);
 
                 return $params;
             },