Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwooleContextHandler.php #209

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

anoxia
Copy link
Contributor

@anoxia anoxia commented Nov 10, 2023

If the exception in the coroutine is not caught or other unknown circumstances, the code stack will run in a non-coroutine. At this time, Coroutine::getPcid($pcid) will return false, and SwooleContextHandler::isForked(int id) will raise a TypeError. fatal error.

If the exception in the coroutine is not caught or other unknown circumstances, the code stack will run in a non-coroutine. At this time, Coroutine::getPcid($pcid) will return false, and SwooleContextHandler::isForked(int id) will raise a TypeError. fatal error
@anoxia anoxia requested a review from a team November 10, 2023 02:52
Copy link

welcome bot commented Nov 10, 2023

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Nov 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Anoxia / name: 路易港 (86d7ebb)

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #209 (7dcf5f3) into main (3d811bd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 7dcf5f3 differs from pull request most recent head 86d7ebb. Consider uploading reports for the commit 86d7ebb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #209      +/-   ##
============================================
- Coverage     33.12%   33.09%   -0.04%     
- Complexity      852      853       +1     
============================================
  Files            76       76              
  Lines          3248     3248              
============================================
- Hits           1076     1075       -1     
- Misses         2172     2173       +1     
Flag Coverage Δ
7.4 46.34% <0.00%> (ø)
8.0 26.09% <0.00%> (-7.70%) ⬇️
8.1 33.42% <0.00%> (+0.33%) ⬆️
8.2 26.78% <0.00%> (-6.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Context/Swoole/src/SwooleContextHandler.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d811bd...86d7ebb. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Nov 10, 2023

LGTM - thanks @anoxia !
Since you are using this successfully, we'd really love a documentation patch (eg to the README) which describes how to set it up and use it. The original author didn't supply this :(

@brettmc brettmc merged commit 3db80bd into open-telemetry:main Nov 10, 2023
58 checks passed
@anoxia
Copy link
Contributor Author

anoxia commented Nov 10, 2023

@brettmc
Okay, I will do it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants