-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record spans for symfony messenger #215
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
============================================
+ Coverage 85.85% 85.94% +0.09%
- Complexity 883 888 +5
============================================
Files 80 81 +1
Lines 3393 3493 +100
============================================
+ Hits 2913 3002 +89
- Misses 480 491 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
PSR-3 testsuite is broken.. |
@cedricziel you can leave the psr3 failures to me, those tests haven't been running previously. |
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
The psr-3 failures are sort of xdebug-related. I was able to replicate this locally, and it occurs when running the .phpt tests with coverage enabled, whilst actually generating coverage. eg So, #217 is a compromise: we run all tests without generating coverage (which includes any phpt tests), and generate coverage only off the unit & integration suites. The reason this failed to fail previously is that |
@cedricziel merging in main should make the build green. |
Done @brettmc ! Thanks for the thorough review! 🙏 |
This instrumentation adds spans for the Symfony messenger component.
It creates:
Nota bene: