Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-sdk-extension-aws: make eks detector less chatty #3074

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Dec 6, 2024

Description

Don't print warnings if we are not running inside an eks instance so we can load the resource detector more generally and avoid warnings in stderr.

Detector in the go implementation is doing the same https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/detectors/aws/eks/detector.go#L142

Refs #3075

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-test-sdk-extension-aws-1

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

CHANGELOG.md Outdated Show resolved Hide resolved
@xrmx xrmx force-pushed the less-spammy-eks-detector branch from 2fdf997 to 304ef97 Compare December 9, 2024 09:42
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 9, 2024
@xrmx xrmx removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 9, 2024
xrmx added 2 commits December 9, 2024 11:10
Don't print warnings if we are not running inside an eks instance so we can load the
resource detector more generally and avoid warnings in stderr.
@xrmx xrmx force-pushed the less-spammy-eks-detector branch from 304ef97 to 4b20aeb Compare December 9, 2024 10:10
@xrmx xrmx enabled auto-merge (squash) December 13, 2024 15:34
@xrmx xrmx merged commit 38f0e33 into open-telemetry:main Dec 13, 2024
573 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants