Skip to content

Commit

Permalink
Experiment with running rubocop without rake
Browse files Browse the repository at this point in the history
  • Loading branch information
kaylareopelle committed Jan 19, 2024
1 parent faaaa9b commit 499a6cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/actions/test_gem/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ runs:
if: "${{ inputs.rubocop == 'true' }}"
run: |
# 🤖 Rubocop 🤖
bundle exec rake rubocop
bundle exec rubocop
working-directory: "${{ steps.setup.outputs.gem_dir }}"

- name: Build Gem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ module Bunny
# For additional details around trace messaging semantics
# See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#messaging-attributes
module PatchHelpers
def self.with_send_span(channel, tracer, exchange, routing_key, &block) # rubocop:disable Style/ArgumentsForwarding, Lint/RedundantCopDisableDirective
def self.with_send_span(channel, tracer, exchange, routing_key, &block) # rubocop:disable Style/ArgumentsForwarding
attributes = basic_attributes(channel, channel.connection, exchange, routing_key)
destination = destination_name(exchange, routing_key)

tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) # rubocop:disable Style/ArgumentsForwarding, Lint/RedundantCopDisableDirective
tracer.in_span("#{destination} publish", attributes: attributes, kind: :producer, &block) # rubocop:disable Style/ArgumentsForwarding
end

def self.with_process_span(channel, tracer, delivery_info, properties, &block) # rubocop:disable Style/ArgumentsForwarding
Expand Down

0 comments on commit 499a6cf

Please sign in to comment.