refactor: move methods around

open-telemetry · Sep 24, 2023 · 63b902f · 63b902f
1 parent e7344ae
commit 63b902f
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/instrumentation/active_job/lib/opentelemetry/instrumentation/active_job/subscriber.rb b/instrumentation/active_job/lib/opentelemetry/instrumentation/active_job/subscriber.rb
@@ -96,21 +96,17 @@ def on_start(name, _id, payload, subscriber)
       end
 
       class Subscriber < ::ActiveSupport::Subscriber
-        EVENT_HANDLERS = {
-          'enqueue.active_job' => EnqueueSubscriber.new(OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')),
-          'perform.active_job' => PerformSubscriber.new(OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')),
-        }
+        attr_reader :tracer
 
         def initialize(...)
           super
+          @tracer = OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')
           @handlers_by_pattern = {
-            'enqueue.active_job' => EnqueueSubscriber.new(OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')),
-            'perform.active_job' => PerformSubscriber.new(OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')),
+            'enqueue.active_job' => EnqueueSubscriber.new(@tracer),
+            'perform.active_job' => PerformSubscriber.new(@tracer),
           }
         end
 
-        attach_to :active_job
-
         # The methods below are the events the Subscriber is interested in.
         def enqueue(...); end
         def perform(...);end
@@ -177,9 +173,7 @@ def as_otel_semconv_attrs(job)
           otel_attributes
         end
 
-        def tracer
-          OpenTelemetry.tracer_provider.tracer('otel-active_job', '0.0.1')
-        end
+        attach_to :active_job
       end
     end
   end