Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ActiveSupport from top-level namespace #1123

Merged

Conversation

ryanharkins
Copy link
Contributor

Description

Came across an error when ActiveRecord Instrumentation is being installed in a Rails app.

Proposed change

Use ::ActiveSupport to look for constant in the top-level namespace.

Error:

OpenTelemetry error: Instrumentation: OpenTelemetry::Instrumentation::ActiveRecord unhandled exception during install:
...
undefined method `on_load' for OpenTelemetry::Instrumentation::ActiveSupport:Module
...
ActiveSupport.on_load(:active_record) do
             ^^^^^^^^

Copy link

linux-foundation-easycla bot commented Aug 18, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@arielvalentin arielvalentin merged commit 9ce7e39 into open-telemetry:main Aug 19, 2024
57 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
@ryanharkins ryanharkins deleted the fix-active-record-install-error branch August 19, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants