Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update references to logging exporter #1178

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Sep 20, 2024

This exporter has been replaced by the debug exporter and will be removed soon

Related to open-telemetry/opentelemetry-collector#11037

This exporter has been replaced by the debug exporter and will be removed soon

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten changed the title examples: update references to logging exporter fix: update references to logging exporter Sep 20, 2024
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codeboten!

Thanks for your contribution!

Unfortunately, this repo has similar problems to opentelemetry-ruby, in that it also uses a version of the collector that predates the debug exporter (though this repo uses 0.54.0, rather than 0.35.0).

See this comment on the other PR for more details: open-telemetry/opentelemetry-ruby#1731 (review)

I'd appreciate your help getting things working if you have the time to assist! I imagine the fixes for one of the repos could easily translate to the other.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
Copy link
Contributor Author

Updated the example in this repo as well and got a trace in jaeger

Screenshot 2024-09-20 at 12 45 39 PM

Note that I was getting some errors from instrumentations when i ran docker compose up, but i didn't have time to dig into those

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me too! Good to know about the errors. I didn't see anything that needed immediate attention. Thank you, @codeboten!

@kaylareopelle kaylareopelle merged commit 0a7f9e7 into open-telemetry:main Oct 1, 2024
57 checks passed
@codeboten codeboten deleted the codeboten/rm-logging-references branch October 1, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants