Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add Rails 7.2 to Appraisals #1242

Merged
merged 16 commits into from
Nov 19, 2024
Merged

test: Add Rails 7.2 to Appraisals #1242

merged 16 commits into from
Nov 19, 2024

Conversation

arielvalentin
Copy link
Collaborator

Now that Rails 8 has been released, we need to make sure our appraisals are up to date to explicitly include Rails 7.2

@arielvalentin arielvalentin self-assigned this Nov 15, 2024
@arielvalentin arielvalentin marked this pull request as draft November 16, 2024 16:33
@arielvalentin arielvalentin marked this pull request as ready for review November 19, 2024 05:07
@arielvalentin arielvalentin enabled auto-merge (squash) November 19, 2024 13:48
kaylareopelle
kaylareopelle approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ariel! Do you think we should mention this now tests Rails 8.0 too?

Also, I saw earlier test runs where Rails 2.3 was installed instead of the latest version on some gems. Did the appraisal clean addition fix that?

@arielvalentin arielvalentin merged commit 37584d0 into open-telemetry:main Nov 19, 2024
57 checks passed
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

Assignees

@arielvalentin arielvalentin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielvalentin @kaylareopelle