Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Experiment with GCP Release Please #729

Merged
merged 9 commits into from
Dec 22, 2023

Conversation

arielvalentin
Copy link
Collaborator

@arielvalentin
Copy link
Collaborator Author

@kaylareopelle if you all have any monorepos in use I could use help/pointers because this is like a very minimal configuration and I am not sure if I am holding it right.

@kaylareopelle kaylareopelle self-requested a review December 7, 2023 23:15
@kaylareopelle
Copy link
Contributor

I found opentelemetry-js-contrib added it in 2021: open-telemetry/opentelemetry-js-contrib#659

I think the missing piece is a release-please-config.json file: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/659/files#diff-c55d4dcb68c348b2c06d263819702fbce72eeeb35b662956d02049a5a18fcf2b

@arielvalentin
Copy link
Collaborator Author

@kaylareopelle great that you found that because I implemented this incorrectly and thought the manifest JSON was the same as the config JSON file.

I pushed up a commit that sets the files with what I believe are the correct configurations now.

@arielvalentin arielvalentin self-assigned this Dec 21, 2023
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ariel! I think this looks good. I have one comment, but JIC we don't need to take action, this is approved!

- uses: google-github-actions/release-please-action@cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e
id: release
with:
command: manifest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using built in actions tokens instead of PATs.

Built in tokens have a limitation that they don't trigger other actions if a bot performs the actions, which is why say when the bot opens a PR it does not end up triggering unit tests.

I didn't want to start using PATs because then it would be linked to one of our accounts so I figured that I'd live with the consequences and do things like have to manually run tests myself.

If we run into any issues with this flow then I'll switch to using pats.

One thing I haven't figured out yet is how to deal with dependencies yet, e.g. bumping AS and then bumping Rails then all etc...

@arielvalentin arielvalentin requested a review from a team December 22, 2023 21:30
@arielvalentin arielvalentin merged commit fd5b9a7 into open-telemetry:main Dec 22, 2023
47 checks passed
@arielvalentin arielvalentin deleted the gcp-release-please branch December 22, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants