-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Experiment with GCP Release Please #729
chore: Experiment with GCP Release Please #729
Conversation
An experiment to replace toys. https://github.com/google-github-actions/release-please-action/tree/main
@kaylareopelle if you all have any monorepos in use I could use help/pointers because this is like a very minimal configuration and I am not sure if I am holding it right. |
I found opentelemetry-js-contrib added it in 2021: open-telemetry/opentelemetry-js-contrib#659 I think the missing piece is a |
@kaylareopelle great that you found that because I implemented this incorrectly and thought the manifest JSON was the same as the config JSON file. I pushed up a commit that sets the files with what I believe are the correct configurations now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ariel! I think this looks good. I have one comment, but JIC we don't need to take action, this is approved!
- uses: google-github-actions/release-please-action@cc61a07e2da466bebbc19b3a7dd01d6aecb20d1e | ||
id: release | ||
with: | ||
command: manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS has a few more keys here. Do we need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using built in actions tokens instead of PATs.
Built in tokens have a limitation that they don't trigger other actions if a bot performs the actions, which is why say when the bot opens a PR it does not end up triggering unit tests.
I didn't want to start using PATs because then it would be linked to one of our accounts so I figured that I'd live with the consequences and do things like have to manually run tests myself.
If we run into any issues with this flow then I'll switch to using pats.
One thing I haven't figured out yet is how to deal with dependencies yet, e.g. bumping AS and then bumping Rails then all etc...
An experiment to replace toys.
https://github.com/google-github-actions/release-please-action/tree/main