Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(trilogy): change db.mysql.instance.address to db.instance.id #758

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

dlahn
Copy link
Contributor

@dlahn dlahn commented Dec 7, 2023

fixes #745

@arielvalentin
Copy link
Collaborator

@dlahn would you mind recategorizing the commit as feat!?

This will create a minor bump and alert folks that there is a "breaking change" since an attribute they may depend on will no longer be present.

@dlahn
Copy link
Contributor Author

dlahn commented Dec 8, 2023

@arielvalentin Sure. Done!

@dlahn dlahn changed the title refactor(trilogy): change db.mysql.instance.address to db.instance.id feat!(trilogy): change db.mysql.instance.address to db.instance.id Dec 8, 2023
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dlahn!

@arielvalentin arielvalentin merged commit 73fa809 into open-telemetry:main Dec 8, 2023
47 checks passed
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db.instance.id Semantic Convention
3 participants