chore: Update rubocop to 1.60.1 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange. Is there something conflicting in the rubocop versions or the way we run it in CI vs local? |
|
@arielvalentin - It looks like there was a bug with |
kaylareopelle
changed the title
kaylareopelle
force-pushed
the
rubocop-bunny-fix
branch
from
4090ed8 to
52c879d
Compare
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi and
xuan-cao-swi
as code owners
kaylareopelle
force-pushed
the
rubocop-bunny-fix
branch
from
4bf63cf to
966303b
Compare
arielvalentin
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop 1.60.1 fixes an issue with
Style/ArgumentsForwarding, allowing our local and CI rubocop runs to have the same results.