Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop dependency on ruby2_keywords #885

Merged

Conversation

Earlopain
Copy link
Contributor

Now that Ruby below 2.7 is not supported (#389, 38b083a) this is not needed anymore

Now that Ruby below 2.7 is not supported anymore (open-telemetry#389, open-telemetry@38b083a) this is not needed anymore
Copy link

linux-foundation-easycla bot commented Feb 23, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@xuan-cao-swi
Copy link
Contributor

Since you are trying to remove ruby2_keywords dependencies, maybe also need to remove them in active_record/patches/persistence_insert_class_methods.rb

@Earlopain
Copy link
Contributor Author

The ruby2_keywords methods are natively defined in ruby versions after 2.6, all this dependency does is define empty shims for compatibility with older versions (see https://github.com/ruby/ruby2_keywords/blob/3882dac4c9bc784183d7d4cf7374edd56017746f/lib/ruby2_keywords.rb)

Removing these from existing code would change behaviour in some way and I can't say what that entails. It would be better kept for a separate PR.

@arielvalentin arielvalentin merged commit 435481e into open-telemetry:main Feb 23, 2024
50 checks passed
@Earlopain Earlopain deleted the remove-ruby2_keywords-dep branch February 23, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants