Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade async-std v1.13 #2082

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 7, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Upgrades to long awaited async 1.13 async-rs/async-std#1081 - I've checked this still works with rust 1.65 .

I havent added a changelog entry as this doesnt appear to meet the critiera - pls advise if I am wrong about this

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@jayvdb jayvdb requested a review from a team September 7, 2024 06:59
Copy link

linux-foundation-easycla bot commented Sep 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jayvdb / name: John Vandenberg (65cf633)
  • ✅ login: cijothomas / name: Cijo Thomas (021871e, 1da4f4f)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (8f4d64e) to head (1da4f4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2082   +/-   ##
=====================================
  Coverage   78.0%   78.0%           
=====================================
  Files        121     121           
  Lines      20936   20936           
=====================================
  Hits       16332   16332           
  Misses      4604    4604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Sep 7, 2024

I've checked this still works with rust 1.65 .

Is the minimum supported Rust version for async-std not documented?

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 7, 2024

Is the minimum supported Rust version for async-std not documented?

There isnt a rust-version on https://github.com/async-rs/async-std/blob/main/Cargo.toml , and no toolchain file.

Cargo.toml Show resolved Hide resolved
@cijothomas cijothomas merged commit 5269660 into open-telemetry:main Sep 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants