Histogram implementation cleanup #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraillt
force-pushed
the
histogram-impl-cleanup
branch
from
fc5475a
to
e0b962a
Compare
cijothomas
reviewed
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 122 122
Lines 20795 20783 -12
=====================================
- Hits 16512 16506 -6
+ Misses 4283 4277 -6 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Nov 7, 2024
fraillt
force-pushed
the
histogram-impl-cleanup
branch
from
6b422d5
to
d45b5ac
Compare
cijothomas
reviewed
Nov 7, 2024
| let buckets_count = boundaries.len() + 1; | ||
| let mut histogram = Histogram { | ||
| pub(crate) fn new(mut bounds: Vec<f64>, record_min_max: bool, record_sum: bool) -> Self { | ||
| bounds.retain(|v| !v.is_nan()); |
There was a problem hiding this comment.
There are only 3 ways bounds can come from:
- Default. - In this case, sdk provides it so we ensure its already sorted and validated.
- HistogramCreation API - In this case, user provides it, but while creating the instrument, sdk should validate it, and ensure its sorted/validated. If the validation fails, sdk can return the defaults or noop instrument. Opened this issue to track it: Validate user provided Histogram bounds at sdk during Instrument creation time #2286
- Views - In this case also, user provides it, but we should do same as 2.
I believe this method is the wrong place to validate/filter bounds as it should be taken care elsewhere.
Not a blocker for this PR, just added a comment to make sure have same understanding.
There was a problem hiding this comment.
I believe this method is the wrong place to validate/filter bounds as it should be taken care elsewhere.
💯
cijothomas
approved these changes
Nov 7, 2024
utpilla
reviewed
Nov 7, 2024
utpilla
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mostly refactoring by removing unnecessary code, with few minor improvements:
.clone()on buckets indeltacollection.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes