Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Counter/Add benchmark for delta temporality #2285

Merged

Conversation

fraillt
Copy link
Contributor

@fraillt fraillt commented Nov 7, 2024

Changes

Whether it's Cumulative or Delta temporality, there's no difference for in measurement stage, so I removed redudant benchmarks.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fraillt fraillt requested a review from a team as a code owner November 7, 2024 09:21
@fraillt fraillt force-pushed the remove-counter-add-delta-benchmark branch from 4149f0d to 7152894 Compare November 7, 2024 09:23
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (ebf1bb6) to head (7152894).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2285   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        122     122           
  Lines      20795   20795           
=====================================
  Hits       16514   16514           
  Misses      4281    4281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with this cleanup, but i think we should still maintain a stress test+benchmark for delta+cumulative. The perf maybe same, but a benchmark is what users can use to validate that they are indeed same.

(There are scenarios where perf maybe diff. for delta and cumulative even in the update path)

@cijothomas cijothomas merged commit 52f6d92 into open-telemetry:main Nov 7, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants