Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Temporality enum opentelemetry_sdk::metrics::data:: to opentelemetry_sdk::metrics:: #2289

Merged

Conversation

cijothomas
Copy link
Member

Earlier this Enum was used mostly by exporter authors, but this is now used by end users when setting up MeterProvider, so it makes to move it to metrics module directly.

@cijothomas cijothomas requested a review from a team as a code owner November 8, 2024 20:11
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.4%. Comparing base (a707bb9) to head (6261a0b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2289     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        122     122             
  Lines      20783   20783             
=======================================
- Hits       16506   16504      -2     
- Misses      4277    4279      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion regarding the user experience when using the example code. Not a blocker.

Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
@cijothomas cijothomas merged commit 845cf21 into open-telemetry:main Nov 8, 2024
23 of 25 checks passed
@cijothomas cijothomas deleted the cijothomas/move-temporalityenum branch November 8, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants