Remove forgotten TODO text inside specification/logs/supplementary-guidelines.md #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
enesonus
force-pushed
the
remove-forgotten-todo
branch
from
58e6f0a to
f98ded3
Compare
Yes, that seems the intention, and we should probably instead working towards filling that section :D - @open-telemetry/specs-logs-approvers any opinion? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a line with text
TODO: clarify how works or doesn't work when the log statement call site and the log appender are executed on different threads.at supplementary guidelines page of logs specification. This doesn't seem to explain a concept, but rather seems to be a reminder to the author. This PR removes that text.Changes
Removing
TODO: clarify how works or doesn't work when the log statement call site and the log appender are executed on different threads.text from specification/logs/supplementary-guidelines.md