Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that logs attributes are a superset of standard attributes #3852

Merged
merged 22 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9831851
Clarify that logs attributes are a superset of common attributes
pellared Jan 31, 2024
6535104
Update changelog
pellared Jan 31, 2024
2b19cb6
Tidy
pellared Jan 31, 2024
287231e
Align wording for consistency
pellared Jan 31, 2024
5578730
Add hyperlink
pellared Jan 31, 2024
c790658
be -> support
pellared Jan 31, 2024
03dec1a
Update CHANGELOG.md
pellared Jan 31, 2024
e7759b1
Update specification/logs/data-model.md
pellared Jan 31, 2024
c76e1b8
Merge branch 'main' into log-attrs-are-not-common
pellared Jan 31, 2024
8653967
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 1, 2024
8cd0640
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 6, 2024
54d81d4
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 6, 2024
d286bab
Update specification/logs/data-model.md
pellared Feb 6, 2024
7c601a7
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 6, 2024
0a154e3
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 7, 2024
a9093a1
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 14, 2024
8ec1956
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 19, 2024
4e0488a
Update CHANGELOG.md
pellared Feb 19, 2024
a7e8946
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 20, 2024
7abc038
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 23, 2024
c6fa30b
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 26, 2024
87d463e
Merge branch 'main' into log-attrs-are-not-common
pellared Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ release.

- Fix `Resource` field type in Logs Data Model.
([#3826](https://github.com/open-telemetry/opentelemetry-specification/pull/3826))
- Clarify that logs attributes are a superset of common attributes.
pellared marked this conversation as resolved.
Show resolved Hide resolved
([#3852](https://github.com/open-telemetry/opentelemetry-specification/pull/3852))

### Resource

Expand Down
8 changes: 5 additions & 3 deletions specification/logs/data-model.md
Original file line number Diff line number Diff line change
Expand Up @@ -444,13 +444,15 @@ is optional.

### Field: `Attributes`

Type: `map<string, any>`.
Type: [`map<string, any>`](#type-mapstring-any).

Description: Additional information about the specific event occurrence. Unlike
the `Resource` field, which is fixed for a particular source, `Attributes` can
vary for each occurrence of the event coming from the same source. Can contain
information about the request context (other than TraceId/SpanId). SHOULD follow
OpenTelemetry [semantic conventions for attributes](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/README.md).
information about the request context (other than [Trace Context Fields](#trace-context-fields)).
The log attribute model MUST support [`any` type](#type-any),
distinct from [Common Attribute](../common/README.md#attribute) (a superset),
pellared marked this conversation as resolved.
Show resolved Hide resolved
to preserve the semantics of structured attributes emitted by the applications.
This field is optional.

#### Errors and Exceptions
Expand Down
Loading