Clarify enum attribute value stability guarantees #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @open-telemetry/specs-semconv-approvers |
arminru
reviewed
Feb 15, 2024
lmolkova
reviewed
Feb 15, 2024
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
MrAlias
approved these changes
Feb 16, 2024
joaopgrassi
approved these changes
Feb 21, 2024
|
FYI: I have PR to the build-tools to add per-member stability property |
lmolkova
approved these changes
Feb 21, 2024
trask
approved these changes
Feb 21, 2024
carlosalberto
approved these changes
Feb 22, 2024
pellared
approved these changes
Feb 23, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
jsuereth
approved these changes
Feb 27, 2024
jaydeluca
pushed a commit
to jaydeluca/opentelemetry-specification
that referenced
this pull request
Feb 29, 2024
Fixes open-telemetry#3847 ## Changes As discussed in the semantic conventions SIG, this PR aims to clarify stability guarantees provided around well[-known attribute values (aka `enums`) defined by semantic conventions: * Changing an existing `enum` value is a breaking change. * Adding a new value to an `enum` is not a breaking change. ## * [x] Related issues open-telemetry#3847 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) * [ ] Links to the prototypes (when adding or changing features) * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * [ ] [`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md) updated if necessary --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3847 ## Changes As discussed in the semantic conventions SIG, this PR aims to clarify stability guarantees provided around well[-known attribute values (aka `enums`) defined by semantic conventions: * Changing an existing `enum` value is a breaking change. * Adding a new value to an `enum` is not a breaking change. ## * [x] Related issues open-telemetry#3847 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) * [ ] Links to the prototypes (when adding or changing features) * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * [ ] [`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md) updated if necessary --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3847
Changes
As discussed in the semantic conventions SIG, this PR aims to clarify stability guarantees provided around well[-known attribute values (aka
enums) defined by semantic conventions:enumvalue is a breaking change.enumis not a breaking change.CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary