Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adservice] add new adservice ff to demo docs #4172

Merged

Conversation

EislM0203
Copy link
Contributor

This commit add the adServiceManualGc feature flag to the opentelemetry demo docs.

The feature flag triggers full manual garbage collections in the ad service.

Upstream PR can be found here: open-telemetry/opentelemetry-demo#1463

This commit add the adServiceManualGc feature flag to the opentelemetry demo docs

The feature flag triggers full manual garbage collections in the ad service
@cartermp cartermp added the sig-approval-missing Co-owning SIG didn't provide an approval label Mar 18, 2024
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the PR on the demo side gets merged, we can merge this.

@cartermp cartermp added blocked upstream and removed sig-approval-missing Co-owning SIG didn't provide an approval labels Mar 19, 2024
@julianocosta89
Copy link
Member

@cartermp this one should be good to go! 🎉

@cartermp cartermp merged commit 841db79 into open-telemetry:main Mar 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants