-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare upgrade to Django 4.2 #125
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 90.96% 90.90% -0.06%
==========================================
Files 88 88
Lines 2346 2343 -3
Branches 258 257 -1
==========================================
- Hits 2134 2130 -4
- Misses 185 186 +1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would advise only upgrading packages related to django itself, so things like black/isort etc. you really want to do in a separate PR
Sorting out the django-related packages will already be complicated enough. I'd even go so far as to make a PR per package upgrade.
That's why I went with separate commits for each, separate PRs would end up in a rebase nightmare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Viicos Could you please rebase on main and resolve the conflicts?
5420d28
to
735682f
Compare
Update `asgiref` to avoid compat issue
@annashamray The Django 4.2 upgrade will have to be done in a separate PR -- I don't have more time to work on this, and there are still things to be handled (especially zgw consumers/zds client) |
Fixes #124