Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare upgrade to Django 4.2 #125

Merged
merged 13 commits into from
Apr 3, 2024
Merged

Prepare upgrade to Django 4.2 #125

merged 13 commits into from
Apr 3, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jan 9, 2024

Fixes #124

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.90%. Comparing base (8f5516c) to head (39ccd23).

Files Patch % Lines
src/nrc/conf/local_example.py 0.00% 3 Missing ⚠️
src/nrc/accounts/models.py 0.00% 1 Missing ⚠️
src/nrc/conf/includes/base.py 92.85% 0 Missing and 1 partial ⚠️
src/nrc/wsgi.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   90.96%   90.90%   -0.06%     
==========================================
  Files          88       88              
  Lines        2346     2343       -3     
  Branches      258      257       -1     
==========================================
- Hits         2134     2130       -4     
- Misses        185      186       +1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advise only upgrading packages related to django itself, so things like black/isort etc. you really want to do in a separate PR

Sorting out the django-related packages will already be complicated enough. I'd even go so far as to make a PR per package upgrade.

@Viicos
Copy link
Contributor Author

Viicos commented Jan 9, 2024

I would advise only upgrading packages related to django itself, so things like black/isort etc. you really want to do in a separate PR

Sorting out the django-related packages will already be complicated enough. I'd even go so far as to make a PR per package upgrade.

That's why I went with separate commits for each, separate PRs would end up in a rebase nightmare

Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Viicos Could you please rebase on main and resolve the conflicts?

@Viicos Viicos force-pushed the chore/124-upgrade branch from 5420d28 to 735682f Compare April 3, 2024 08:39
@Viicos Viicos changed the title Upgrade to Django 4.2 Prepare upgrade to Django 4.2 Apr 3, 2024
@Viicos
Copy link
Contributor Author

Viicos commented Apr 3, 2024

@annashamray The Django 4.2 upgrade will have to be done in a separate PR -- I don't have more time to work on this, and there are still things to be handled (especially zgw consumers/zds client)

@annashamray annashamray merged commit 4438296 into main Apr 3, 2024
13 checks passed
@annashamray annashamray deleted the chore/124-upgrade branch April 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Django 4.2 in Open Notificaties
4 participants