Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17] add jobs for checking for changes for OAS files #167

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[#17] add jobs for checking for changes for OAS files #167

merged 3 commits into from
Jul 17, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Jun 28, 2024

No description provided.

@SonnyBA SonnyBA marked this pull request as ready for review June 28, 2024 13:34
@SonnyBA SonnyBA self-assigned this Jun 28, 2024
annashamray
annashamray approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in Open Zaak: I think this check is better to be located in code-quality action, but it's up to you

@SonnyBA SonnyBA merged commit 20732e0 into main Jul 17, 2024
16 checks passed
@SonnyBA SonnyBA deleted the issue/#17-oas-ci-check branch July 17, 2024 08:47
@SonnyBA
Copy link
Contributor Author

SonnyBA commented Jul 17, 2024

This partially fixed maykinmedia/open-api-framework#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray approved these changes

@stevenbal stevenbal stevenbal approved these changes

@Coperh Coperh Awaiting requested review from Coperh

Assignees

@SonnyBA SonnyBA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SonnyBA @stevenbal @annashamray