Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of client/server config with ZeroMQ #3

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Oct 10, 2023

Add a description
Currently, the proxy uses the Push/Pull messaging pattern of ZeroMQ. In this PR, the Client/Server pattern was additionally implemented. The user can choose with an FMI parameter, which config he wants to use. With the Client/Server pattern, the sender waits for the receiver to be ready before sending the message.

Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review

  • My suggestion follows the governance rules.
  • All commits of this PR are signed.
  • My changes generate no errors when passing CI tests.
  • I updated all documentation (readmes incl. figures) according to my changes.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff self-assigned this Oct 10, 2023
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff merged commit b6f5f76 into main Oct 10, 2023
6 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the server-client-config branch October 10, 2023 16:46
@github-actions
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 5 concern(s)
  • src/OSMP.cpp

    /src/OSMP.cpp:50:16: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'private_log_file' is non-const and globally accessible, consider making it const

    ofstream OSMP::private_log_file;
                   ^
  • src/OSMP.h

    /src/OSMP.h:134:21: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'private_log_file' is non-const and globally accessible, consider making it const

        static ofstream private_log_file;
                        ^

    /src/OSMP.h:134:21: warning: [readability-identifier-naming]

    invalid case style for class member 'private_log_file'

        static ofstream private_log_file;
                        ^~~~~~~~~~~~~~~~
                        g_private_log_file

    /src/OSMP.h:164:21: warning: [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

    1024 is a magic number; consider replacing it with a named constant

            char buffer[1024];
                        ^

    /src/OSMP.h:168:27: warning: [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]

    1024 is a magic number; consider replacing it with a named constant

            vsnprintf(buffer, 1024, format, arg);
                              ^

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant