Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21 #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #21 #36

wants to merge 1 commit into from

Conversation

gyr
Copy link
Member

@gyr gyr commented Mar 15, 2023 •
edited by SchoolGuy
Loading

Fixes #21

@gyr
Copy link
Member Author

gyr commented Mar 15, 2023

The problem with the failed tests is that osc version is >=1.0 on TW and openSUSE:Tools repositories, however, only version 0.182.0 is available via pip

@SchoolGuy
Copy link
Contributor

@dmach Can you maybe help out with the mentioned issue please?

@SchoolGuy SchoolGuy linked an issue Mar 15, 2023 that may be closed by this pull request
list-accepted-pkgs is returning all packages not only the accepted ones #21
Open
@SchoolGuy SchoolGuy self-requested a review March 15, 2023 21:09
SchoolGuy
SchoolGuy reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in my eyes. However, we should wait for @dmach to appear and ask him what to do with this situation. When we merge this in the current state, we would break installation from pip.

@dmach
Copy link

dmach commented Mar 17, 2023

@gyr @SchoolGuy I've recently learned that the API endpoint behind core.get_request_collection() is tailored mainly to the osc my command. I'll take a look at this if we shouldn't use a different function and API call. I'll reach back to you early next week.

@dmach
Copy link

dmach commented Mar 20, 2023

I'm planning a new search API in osc using /search/request?match=, but it requires some fixes in OBS.
The get_request_collection() function uses an endpoint that may return more than you would anticipated (includes also source projects and projects associated as a reviewer). Check the updated documentation which is not public yet: https://github.com/openSUSE/open-build-service/pull/13915/files
I think that neither of that is possible in your use case and eventually you could filter the result by removing everything that doesn't match the specified project.

Would you be fine with using get_request_collection() now and migrating to another osc API once it's completed?

@SchoolGuy
Copy link
Contributor

@gyr is the one that should decide it. I have nothing against it personally.

@gyr gyr force-pushed the fix-issue-21 branch 2 times, most recently from a7d8efc to fc7f7c8 Compare April 3, 2023 17:21
SchoolGuy
SchoolGuy approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed in the Huddle just now: Please ensure the Packaging CI is green before we merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

list-accepted-pkgs is returning all packages not only the accepted ones
3 participants
@gyr @SchoolGuy @dmach