Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop two datasets from steganography #1477

Closed
wants to merge 3 commits into from
Closed

Drop two datasets from steganography #1477

wants to merge 3 commits into from

Conversation

thesofakillers
Copy link
Contributor

@thesofakillers thesofakillers commented Mar 11, 2024 •
edited
Loading

Removing two datasets:

  • PiC/phrase_similarity
  • vicgalle/alpaca-gpt4

Impact on Steganography:

  • Only marginal change in data distribution.
  • We modify the sampling counts such that we have the same total number of samples as before.
  • Did not re-run results; absolute scores should change but qualitative interpretation of eval will not be different.

@thesofakillers thesofakillers marked this pull request as draft March 11, 2024 10:49
@JunShern JunShern marked this pull request as ready for review March 12, 2024 04:49
@JunShern
Copy link
Collaborator

Piggybacking this PR to add a small fix for the OpenAIAssistantsSolver which was causing tests to fail. 0360e4c

@JunShern JunShern self-requested a review March 12, 2024 04:50
JunShern
JunShern approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@JunShern JunShern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thesofakillers
Copy link
Contributor Author

Closing this due to merge issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunShern JunShern JunShern approved these changes

@andrew-openai andrew-openai Awaiting requested review from andrew-openai andrew-openai is a code owner

@etr2460 etr2460 Awaiting requested review from etr2460 etr2460 is a code owner

@katyhshi katyhshi Awaiting requested review from katyhshi katyhshi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesofakillers @JunShern