Introduce new eAVControl

[jbleyel]

• this new class will be the successor for eAVSwitch
• add several new AV proc functions

[persianpros]

Wonderful, more C/C++ code instead of python makes e2 faster and more stable 👍

There are many places in e2 which affect A/V settings and they all seem like duplicates, I hope you eliminate them all and use this new class.

[jbleyel]

Wonderful, more C/C++ code instead of python makes e2 faster and more stable 👍

There are many places in e2 which affect A/V settings and they all seem like duplicates, I hope you eliminate them all and use this new class.

That's the plan. I will move as much as I can to AVControl and remove the duplicate code.

[IanSav]

There was a more significant logic other than performance improvements. We went for the C++ option as we get to use conditional compilation that is appropriate for every box built. This means that a significant amount of Python code with lots of hardware based "if" logic can be eliminated. We now get the data needed by Python without having to work out the type of hardware upon which we are running. The only code being moved to C++ is the code used to directly interface with the hardware. All the UI and user facing code is still in Python.

[wedebe]

Shouldn't such a significant change go into the next version (7.3) instead of master (7.2)?

[jbleyel]

Shouldn't such a significant change go into the next version (7.3) instead of master (7.2)?

The master branch is version 7.3.
This means all changes in master will NOT come in 7.2 except small changes or bugfixes.

[persianpros]

I think https://github.com/openatv/enigma2/blob/eAVControl/lib/driver/avcontrol.cpp#L121 is wrong and should be "framerate"

[jbleyel]

I think https://github.com/openatv/enigma2/blob/eAVControl/lib/driver/avcontrol.cpp#L121 is wrong and should be "framerate"

Fixed .. thanks

[persianpros]

Seems parts of the code is not compatible with newer C++ which we're using:

error: no match for 'operator=' (operand types are 'const std::string' {aka 'const std::__cxx11::basic_string<char>'} and 'std::string' {aka 'std::__cxx11::basic_string<char>'}) 203 | m_video_mode_60 = CFile::read(proc_videomode_60); | ^

Also https://github.com/openatv/enigma2/blob/eAVControl/lib/driver/avcontrol.cpp#L174 is not defined maybe

std::string check = CFile::read(proc_hdmi_rx_monitor);

?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
16 Code Smells

No Coverage information
0.0% Duplication

[persianpros]

@jbleyel

Well done for this huge improvement 🥇

Just to let you know you could merge both ServiceReference.py files and only use one like OV 👍

[jbleyel]

@jbleyel

Well done for this huge improvement 🥇

Just to let you know you could merge both ServiceReference.py files and only use one like OV 👍

DONE , thanks for the hint.