Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember table sorting #1009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Dec 12, 2024

Tables can be sorted by columns, ascending or descending. However, when switching to a different tab and back again, the sorting reverts to the default. With this change, the sorting is remembered.

Does not persist the sorting, meaning it still reverts to the default after a page reload. I did not do this because the only to way to get rid of persisted sorting would be to the clear the browsers cache, and I did not want alienate people.

Also sneakily changes the default sorting of the series table in the same way as #1008.

How to test this

PR can be tested as is, no other dependencies or configuration necessary.

Bildschirmaufzeichnung.vom.2024-12-12.11-44-03.webm

Tables can be sorted by columns, ascending or
descending. However, when switching to a
different tab and back again, the sorting reverts
to the default. With this change, the sorting is
remembered.

Does not persist the sorting, meaning it still
reverts to the default after a page reload.
I did not do this because the only to way to
get rid of persisted sorting would be to the
clear the browsers cache, and I did not want
alienate people.

Also sneakily changes the default sorting
of the series table in the same way as opencast#1008.
@Arnei Arnei added the type:usability Improves the UX label Dec 12, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1009/2024-12-12_10-46-46/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1009

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1009

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Improves the UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant