Theme upload validation workaround #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The created rquested to /staticfiles were not matching our proxy regex. This fixes that.
When trying to create a theme, you can upload files. After the upload completes, you should be able to proceed to the next step. However, the "Next" button remained disabled, making it impossible to proceed. (Well, not actually impossible, going a step back and then forward again would fix the issue, but w/e). This fixes that, but crudely. We may want to rewrite the theme dialog because uploading each file individually and forcing the user to wait on that seems pretty bad UX to me.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1025/2024-12-20_13-22-51/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully helps in part with #915.
When trying to create a theme, you can upload files. After the upload completes, you should be able to proceed to the next step. However, the "Next" button remained disabled, making it impossible to proceed. (Well, not actually impossible, going a step back and then forward again would fix the issue, but w/e).
This fixes that, but crudely. We may want to rewrite the theme dialog because uploading each file individually and forcing the user to wait on that seems pretty bad UX to me.
Includes #1024.
How to test this
You will need an Opencast with themes enabled to test this against, so you can test the various theme dialogs.