Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unspecified filter on clear #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 15, 2025

The clear button clears the table filter field of all selected filters. It will however not remove an unspecified filter, meaning the dropdown menu. This patch makes is so that so that those are cleared as well, making sure the filter area is really clear.

Bildschirmfoto vom 2025-01-16 08-53-36

How to test this

Can be tested as usual.

The clear button clears the table filter field of
all selected filters. It will however not remove
an unspecified filter, meaning the dropdown
menu. This patch makes is so that so that those
are cleared as well, making sure the filter area
is really clear.
@Arnei Arnei added the type:bug Something isn't working label Jan 15, 2025
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1072/2025-01-15_16-32-07/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1072

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1072

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant