Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to checkboxes on Events tab. #558

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

luniki
Copy link
Contributor

@luniki luniki commented Jun 4, 2024

Fixes #536

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Hi @luniki
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/558/2024-06-04_10-27-37/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-558

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-558

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@Arnei Arnei self-assigned this Jun 4, 2024
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says.

Since atm we have zero aria-labels in this project, do you have any recommendations on a unified approach towards adding them where they belong (and avoid adding them where they don't belong or are not needed)?

@ziegenberg ziegenberg added the type:accessibility This would help impaired users label Jun 4, 2024
@luniki
Copy link
Contributor Author

luniki commented Jun 4, 2024

Does what it says.

Since atm we have zero aria-labels in this project, do you have any recommendations on a unified approach towards adding them where they belong (and avoid adding them where they don't belong or are not needed)?

I cant' cite an exhaustive list. There is of course an easy rule: All form elements have to be labelled in any way. (see for example https://act-rules.github.io/rules/e086e5)

@Arnei Arnei merged commit 3aacb53 into opencast:main Jun 5, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkboxes on Events tab are not labelled
3 participants