Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @mui/material's Tooltip instead of title attributes. #593

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

luniki
Copy link
Contributor

@luniki luniki commented Jun 5, 2024

Fixes #574

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-593

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-593

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the build issues?

@ziegenberg ziegenberg added the type:accessibility This would help impaired users label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/593/2024-06-07_04-21-14/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@ziegenberg
Copy link
Member

Hi @luniki,
could you fix the merge conflicts?

@luniki luniki force-pushed the a11y/enhanced-tooltips branch from c92270a to c4d9446 Compare June 7, 2024 04:14
@luniki luniki force-pushed the a11y/enhanced-tooltips branch from c4d9446 to 7214f06 Compare June 7, 2024 04:21
@luniki
Copy link
Contributor Author

luniki commented Jun 7, 2024

Hi @luniki, could you fix the merge conflicts?

Done

@lkiesow lkiesow self-assigned this Jun 7, 2024
@lkiesow lkiesow merged commit 94e21d2 into opencast:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve design and accessibility of tooltips
3 participants