-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wf config values not showing for scheduled events #978
Fix wf config values not showing for scheduled events #978
Conversation
When looking at the workflow tab of a scheduled event, the workflow configuration for the workflow would always display default values, regardless of what was initially set. This should fix that.
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/978/2024-11-06_10-36-02/ . |
The workflow config parameters are now displayed correctly for scheduled events, but I can't change them. For example, if I uncheck one of the checkboxes and try to save it, I get the following error in the Opencast logs:
|
Opencast was throwing an error because it expects all workflow config values to be strings. No idea wether that makes sense or not, but this should change our PUT request to give Opencast what it expects.
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
Thanks for reminding me, completely forgot that while fixing the config parameter display. The error you mentioned should be fixed with the latest commit, so you should be able to change parameter values now. |
This pull request is deployed at test.admin-interface.opencast.org/978/2024-11-11_11-41-54/ . |
Thanks for this fix! I'm now also able to change the workflow parameters. |
Works mostly as expected. If I change something and leave the dialog without saving, the interface usually prompts the user if they are sure about leaving without saving first. That's not happening here. I think, it should. That being said, if you don't have time to fix that, I'm fine with merging it as-is. It's still a big improvement after all. |
Good catch. I'd prefer if we could handle that in a separate issue. |
Okay. Created #982 |
Fixes #916.
When looking at the workflow tab of a scheduled event, the workflow configuration for the workflow would always display default values, regardless of what was initially set. This should fix that.
Example screenshot:
(Disclaimer: Using the duplicate event workflow for a scheduled event makes no sense, it is used here purely for demonstration purposes)