Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wf config values not showing for scheduled events #978

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Nov 6, 2024

Fixes #916.

When looking at the workflow tab of a scheduled event, the workflow configuration for the workflow would always display default values, regardless of what was initially set. This should fix that.

Example screenshot:
Bildschirmfoto vom 2024-11-06 11-34-45
(Disclaimer: Using the duplicate event workflow for a scheduled event makes no sense, it is used here purely for demonstration purposes)

When looking at the workflow tab of a scheduled
event, the workflow configuration for the workflow
would always display default values, regardless
of what was initially set. This should fix that.
@Arnei Arnei added the type:bug Something isn't working label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-978

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-978

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

This pull request is deployed at test.admin-interface.opencast.org/978/2024-11-06_10-36-02/ .
It might take a few minutes for it to become available.

@snoesberger
Copy link

The workflow config parameters are now displayed correctly for scheduled events, but I can't change them. For example, if I uncheck one of the checkboxes and try to save it, I get the following error in the Opencast logs:

org.opencastproject.scheduler.api.SchedulerException: java.lang.ClassCastException: class java.lang.Boolean cannot be cast to class java.lang.String (java.lang.Boolean and java.lang.String are in module java.base of loader 'bootstrap')

Opencast was throwing an error because it
expects all workflow config values to be
strings. No idea wether that makes sense or not,
but this should change our PUT request to
give Opencast what it expects.
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-978

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-978

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@Arnei
Copy link
Member Author

Arnei commented Nov 11, 2024

Thanks for reminding me, completely forgot that while fixing the config parameter display. The error you mentioned should be fixed with the latest commit, so you should be able to change parameter values now.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/978/2024-11-11_11-41-54/ .
It might take a few minutes for it to become available.

@snoesberger
Copy link

Thanks for this fix! I'm now also able to change the workflow parameters.

@lkiesow
Copy link
Member

lkiesow commented Nov 18, 2024

Works mostly as expected. If I change something and leave the dialog without saving, the interface usually prompts the user if they are sure about leaving without saving first. That's not happening here. I think, it should.

That being said, if you don't have time to fix that, I'm fine with merging it as-is. It's still a big improvement after all.

@Arnei
Copy link
Member Author

Arnei commented Nov 19, 2024

Good catch. I'd prefer if we could handle that in a separate issue.

@lkiesow
Copy link
Member

lkiesow commented Nov 19, 2024

Okay. Created #982
Merging this

@lkiesow lkiesow merged commit aaf23fb into opencast:main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trying to change the setting of a workflow in the new admin UI does not work
3 participants