-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preselect all capture agent inputs when scheduling new event #979
base: main
Are you sure you want to change the base?
Conversation
When scheduling an event, ensures that all inputs for the capture agent are initially selected. Also fixes a potential source of bugs by cleaning up the selected inputs everytime the capture is changed.
Validation should now take capture agent inputs into account. If inputs are present, at least one will have to be selected.
Currently were displaying the whole translation string for a capture agent input if a translation could not be found, which is rather likely. This commit display the input id in case there is no translation, which should be a reasonable value in most cases. (This is also how it worked in the old admin ui)
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/979/2024-11-12_10-27-29/ . |
I tested this with an Extron SMP (2 inputs, channel A and B) and a pyCA (no input) and it worked as expected for both. I only have a few minor comments:
Perhaps someone who has CAs from other vendors can have a look and see if this works well for them too? |
I'm wondering what our expectations for capture agents are for this. In that sense, we should at least test this with all commonly used agents before merging this:
Or was this behavior already present in the old admin interface? |
Can you guys take a quick poke and see if this change breaks things for you while you're still using GC? |
Ok, though I doubt we'll still be using GC when we eventually deploy this code ;-) |
BTW I assume Zaragoza will be using GC |
This will work fine with GC and matches what we have in the old Admin UI. NOTE: GC can be configured to "hide" the inputs/tracks from OC and just returns |
Aims to fix #941.
When scheduling a new event, if the selected capture agent has any inputs, the inputs are all preselected per default now. At least one input must remain selected. Input name should be rendered nicer now.
Note that these changes are only for when scheduling a new event (except the input name rendering), because the linked issue only talked about scheduling new events. For now I would leave the discussion on how this should work for existing events to a separate issue/pr.
For testing this, a capture agent with inputs must be configured in your Opencast. If you do not have a "real" capture agent, a dummy capture agent can still be configured. See the Opencast docs for more info: https://docs.opencast.org/develop/developer/#architecture/capture-agent/capture-agent-input/#setting-input-options
Quick showcase of the PR in action:
Bildschirmaufzeichnung vom 2024-11-12 11-05-41.webm