Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected filter being lost on tab switch #980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Nov 12, 2024

Fixes #552.

When for example setting a filter for the events table, then switching to the series table and then switching back to the events table, the previously set filter will be lost. This change preserves the filter instead.

When testing this, you may need to clear your browser cache for this to work.

Quick showcase:
Bildschirmaufzeichnung vom 2024-11-12 12-03-42.webm

When for example setting a filter for the events
table, then switching to the series table and then
switching back to the events table, the previously
set filter will be lost. This change preserves the
filter instead.
@Arnei Arnei added the type:bug Something isn't working label Nov 12, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/980/2024-11-12_11-05-59/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-980

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-980

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@snoesberger
Copy link

Thanks for the fix! I have tested it and it works as expected, filters are now persisted when I switch between event and series view.

Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this also breaks the quick filter selection in the admin interface:

opencast-admin-interface-broken-filter-selection.mp4

@Arnei
Copy link
Member Author

Arnei commented Dec 2, 2024

Thanks for catching that.

I am not able to reproduce the bug you found. Do you have futher information? I also tested against develop.opencast.org.
Bildschirmaufzeichnung vom 2024-12-02 16-32-22.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters do not persist when I switch between Event and Series views.
3 participants