Add more admin-UI Tobira endpoints #6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to show links for pages in Tobira that contain a given event.
This was referenced Aug 12, 2024
|
Converted to draft bc we might still need to change some things on the Tobira side, which will then trickle down to this and the admin-UI PR. Edit: these are hopefully fixed, so this is ready for review again. |
owi92
force-pushed
the
add-tobira-event-api
branch
from
79b56ce to
ab72aa3
Compare
owi92
force-pushed
the
add-tobira-event-api
branch
from
ab72aa3 to
357b1e2
Compare
LukasKalbertodt
added a commit
to elan-ev/tobira
that referenced
this pull request
Oct 8, 2024
) This is necessary for an upcoming admin UI feature which will allow admins to change the path of series pages with no other blocks (part of opencast/opencast-admin-interface#311). This shouldn't break any existing behaviour. Related Opencast and admin UI PRs: opencast/opencast#6091, opencast/opencast-admin-interface#878.
This adds a `post` method to update series page paths in Tobira, and also expands some data returned by the `getHostPages` method.
owi92
force-pushed
the
add-tobira-event-api
branch
from
357b1e2 to
7468544
Compare
Arnei
previously requested changes
Oct 29, 2024
modules/admin-ui/src/main/java/org/opencastproject/adminui/endpoint/AbstractEventEndpoint.java
Show resolved
Hide resolved
|
FYI: Branch cut for OC 17 is on November 6! |
Arnei
previously requested changes
Oct 29, 2024
modules/admin-ui/src/main/java/org/opencastproject/adminui/endpoint/AbstractEventEndpoint.java
Show resolved
Hide resolved
Arnei
dismissed
their stale review
"title" refers to the page title, not the event title. Thus, the returned value is technically correct, if not very useful.
Arnei
approved these changes
Oct 29, 2024
|
Well, in that case... 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
This shouldn't break any existing behaviour.
These are needed for additional requirements of opencast/opencast-admin-interface#311.
Corresponding Tobira and admin-UI PRs: elan-ev/tobira#1225, opencast/opencast-admin-interface#878.
Your pull request should…