lib: improve DockerUtils class, #TASK-6445

opencb · Sep 19, 2024 · 0008005 · 0008005
1 parent c5cb58a
commit 0008005
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/commons-lib/src/main/java/org/opencb/commons/utils/DockerUtils.java b/commons-lib/src/main/java/org/opencb/commons/utils/DockerUtils.java
@@ -48,7 +48,13 @@ public static String buildCommandLine(String image, List<AbstractMap.SimpleEntry
                 setUser = false;
             }
             for (String key : dockerParams.keySet()) {
-                commandLine.append("--").append(key).append(" ").append(dockerParams.get(key)).append(" ");
+                if (!key.startsWith("-")) {
+                    commandLine.append("--");
+                }
+                commandLine.append(key).append(" ");
+                if (StringUtils.isNotEmpty(dockerParams.get(key))) {
+                    commandLine.append(dockerParams.get(key)).append(" ");
+                }
             }
         }
 
@@ -62,7 +68,7 @@ public static String buildCommandLine(String image, List<AbstractMap.SimpleEntry
             // Mount management (bindings)
             for (AbstractMap.SimpleEntry<String, String> binding : inputBindings) {
                 commandLine.append("--mount type=bind,source=\"").append(binding.getKey()).append("\",target=\"").append(binding.getValue())
-                        .append("\" ");
+                        .append("\",readonly ");
             }
         }
         commandLine.append("--mount type=bind,source=\"").append(outputBinding.getKey()).append("\",target=\"")