fix tests

opencollective · Feb 27, 2024 · 244b8f1 · 244b8f1
1 parent f19b03c
commit 244b8f1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/server/models/Transaction.ts b/server/models/Transaction.ts
@@ -209,6 +209,7 @@ interface TransactionModelStaticInterface {
   }>;
   createPlatformTipDebtTransactions(args: {
     platformTipTransaction: TransactionInterface;
+    transaction: TransactionCreationAttributes;
   }): Promise<TransactionInterface>;
   createPaymentProcessorFeeTransactions(
     transaction: TransactionCreationAttributes,
@@ -956,14 +957,17 @@ Transaction.createDoubleEntry = async (transaction: TransactionCreationAttribute
  */
 Transaction.createPlatformTipDebtTransactions = async ({
   platformTipTransaction,
+  transaction,
 }: {
   platformTipTransaction: TransactionInterface;
+  transaction: TransactionCreationAttributes;
 }): Promise<TransactionInterface> => {
   if (platformTipTransaction.type === DEBIT) {
     throw new Error('createPlatformTipDebtTransactions must be given a CREDIT transaction');
   }
 
-  const host = await Transaction.fetchHost(platformTipTransaction);
+  // This should be the host of the original transaction
+  const host = await Transaction.fetchHost(transaction);
 
   // Create debt transaction
   const platformTipDebtTransactionData = {
@@ -1075,7 +1079,10 @@ Transaction.createPlatformTipTransactions = async (
 
   let platformTipDebtTransaction;
   if (!transaction.data.isPlatformRevenueDirectlyCollected) {
-    platformTipDebtTransaction = await Transaction.createPlatformTipDebtTransactions({ platformTipTransaction });
+    platformTipDebtTransaction = await Transaction.createPlatformTipDebtTransactions({
+      platformTipTransaction,
+      transaction,
+    });
   }
 
   // If we have platformTipInHostCurrency available, we trust it, otherwise we compute it

diff --git a/test/server/lib/payments.test.js b/test/server/lib/payments.test.js
@@ -443,8 +443,7 @@ describe('server/lib/payments', () => {
         hostFeeInHostCurrency: 250,
         paymentProcessorFeeInHostCurrency: 175,
         description: 'Monthly subscription to Webpack',
-        platformTipAmount: 500,
-        data: { charge: { id: 'ch_refunded_charge' } },
+        data: { charge: { id: 'ch_refunded_charge' }, platformTip: 500 },
       });
 
       // Should have 8 transactions: